From 61d5b3e37b4dc6da4f7da48751b741ad49245cb1 Mon Sep 17 00:00:00 2001
From: Malf Furious <m@lfurio.us>
Date: Thu, 1 Nov 2018 00:03:34 -0400
Subject: Update issue message submit buttons

I'm going to be adding another button down here in the btn-group (more
later).  So to make room, I'm removing the text on these buttons,
leaving only the icons.  The text will instead be a tooltip, visible
when the button is hovered.

In the case of the 'Close issue' button, it is changed from btn-success
to btn-default.  I will tweak colors once this portion of the UI
matures.  For now, I don't want the rainbow in my face.

Signed-off-by: Malf Furious <m@lfurio.us>
---
 app/view/issue.php | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

(limited to 'app/view')

diff --git a/app/view/issue.php b/app/view/issue.php
index 2d781ba..a0e2535 100644
--- a/app/view/issue.php
+++ b/app/view/issue.php
@@ -115,12 +115,12 @@ require_once "class/issue.class.php";
                                 <?=\formctrl\textarea( "New message", "mesg", 5 )?>
 
                                 <div class="btn-group pull-right">
-                                    <button type="submit" name="input[postMesg]" class="btn btn-primary">
-                                        <span class="glyphicon glyphicon-envelope"></span> Post message
+                                    <button type="submit" name="input[postMesg]" class="btn btn-primary" title="Post message">
+                                        <span class="glyphicon glyphicon-envelope"></span>
                                     </button>
 
-                                    <button type="submit" name="input[closeIssue]" class="btn btn-success">
-                                        <span class="glyphicon glyphicon-ok"></span> Close issue
+                                    <button type="submit" name="input[closeIssue]" class="btn btn-default" title="Close issue">
+                                        <span class="glyphicon glyphicon-ok"></span>
                                     </button>
                                 </div>
 
-- 
cgit v1.2.3


From a6853e8a130cfe8f65a154a613f0a7217dd2df0a Mon Sep 17 00:00:00 2001
From: Malf Furious <m@lfurio.us>
Date: Thu, 1 Nov 2018 00:10:48 -0400
Subject: Add advance button to issue message form

If this submit button is used, the message will be posted as usual, then
the issue will be moved to the next stage in the pipeline.

Signed-off-by: Malf Furious <m@lfurio.us>
---
 app/view/issue.php | 4 ++++
 1 file changed, 4 insertions(+)

(limited to 'app/view')

diff --git a/app/view/issue.php b/app/view/issue.php
index a0e2535..67f5627 100644
--- a/app/view/issue.php
+++ b/app/view/issue.php
@@ -122,6 +122,10 @@ require_once "class/issue.class.php";
                                     <button type="submit" name="input[closeIssue]" class="btn btn-default" title="Close issue">
                                         <span class="glyphicon glyphicon-ok"></span>
                                     </button>
+
+                                    <button type="submit" name="input[advIssue]" class="btn btn-default" title="Advance issue">
+                                        <span class="glyphicon glyphicon-chevron-up"></span>
+                                    </button>
                                 </div>
 
                                 <?=\formctrl\file( "Attachment", "attachment" )?>
-- 
cgit v1.2.3


From 23cc51685c5479d487d6416bc7e414e3f8aa60c1 Mon Sep 17 00:00:00 2001
From: Malf Furious <m@lfurio.us>
Date: Sun, 4 Nov 2018 16:36:12 -0500
Subject: Add user interface for issue assignment

This allows users to add assignees when posting to an issue.  A dropdown
is revealed which contains the pad owner and all members.

Signed-off-by: Malf Furious <m@lfurio.us>
---
 app/view/issue.php | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

(limited to 'app/view')

diff --git a/app/view/issue.php b/app/view/issue.php
index 67f5627..5f1c518 100644
--- a/app/view/issue.php
+++ b/app/view/issue.php
@@ -126,6 +126,32 @@ require_once "class/issue.class.php";
                                     <button type="submit" name="input[advIssue]" class="btn btn-default" title="Advance issue">
                                         <span class="glyphicon glyphicon-chevron-up"></span>
                                     </button>
+
+                                    <button type="button" class="btn btn-default" data-toggle="collapse" data-target="#assignCollapse-<?=$i->guid?>" title="Assign issue">
+                                        <span class="glyphicon glyphicon-share-alt"></span>
+                                    </button>
+                                </div>
+
+                                <div class="collapse" id="assignCollapse-<?=$i->guid?>">
+                                    <div class="form-group">
+                                        <label>Select assignee</label>
+
+                                        <select name="input[assignee]" class="form-control selectpicker">
+                                            <option data-icon="glyphicon-user" value="<?=$i->getParent()->getParent()->getOwner()->guid?>">
+                                                <?=$i->getParent()->getParent()->getOwner()->getDisplayName()?>
+                                            </option>
+
+                                            <?php foreach ($i->getParent()->getParent()->getMembers() as $memb) { ?>
+                                                <option data-icon="glyphicon-user" value="<?=$memb->guid?>">
+                                                    <?=$memb->getDisplayName()?>
+                                                </option>
+                                            <?php } ?>
+                                        </select>
+                                    </div>
+
+                                    <button type="submit" name="input[assIssue]" class="btn btn-default">
+                                        <span class="glyphicon glyphicon-share-alt"></span> Post and assign issue
+                                    </button>
                                 </div>
 
                                 <?=\formctrl\file( "Attachment", "attachment" )?>
-- 
cgit v1.2.3


From 434ebff8466ead8f9bb4c0f00037a107cbf842c4 Mon Sep 17 00:00:00 2001
From: Malf Furious <m@lfurio.us>
Date: Mon, 5 Nov 2018 03:32:06 -0500
Subject: Add pad closed issues view

This view is routable from app/<pad_guid>/closed.  It is a separate view
for displaying the closed issues of a pad.  index.php as well as the pad
model code is also updated to support this view.

This view currently *does not* support paging.  This will very likely be
added in the future.

Signed-off-by: Malf Furious <m@lfurio.us>
---
 app/view/pad_closed.php | 64 +++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 64 insertions(+)
 create mode 100644 app/view/pad_closed.php

(limited to 'app/view')

diff --git a/app/view/pad_closed.php b/app/view/pad_closed.php
new file mode 100644
index 0000000..19864cd
--- /dev/null
+++ b/app/view/pad_closed.php
@@ -0,0 +1,64 @@
+<?php
+
+/*
+ * SCROTT IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+ * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
+ * IN NO EVENT SHALL THE AUTHORS BE LIABLE FOR ANY CLAIM, DAMAGES OR
+ * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
+ * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
+ * OTHER DEALINGS IN THE SOFTWARE.
+ *
+ * For more information, please refer to UNLICENSE
+ */
+
+require_once "model/pad.php";
+require_once "view/stdpage.php";
+require_once "view/datalsts.php";
+require_once "view/issue.php";
+
+?>
+
+<!DOCTYPE html>
+
+<html lang="en">
+    <head>
+        <?=stdpage\head( getPageName() )?>
+    </head>
+
+    <body>
+        <?php foreach ($closed_issues as $i) { ?>
+            <?=issue_v\issue($i)?>
+        <?php } ?>
+
+        <?=stdpage\top()?>
+        <?=stdpage\nav()?>
+
+        <div class="container">
+            <div class="well well-lg">
+                <div class="row">
+                    <div class="col-md-12">
+                        <h1>
+                            <span class="glyphicon glyphicon-edit"></span>
+                            <?=$pad->name?>
+
+                            <a href="<?=ar()?>/<?=$pad->guid?>" class="btn btn-default">
+                                View open issues
+                            </a>
+                        </h1>
+                    </div>
+                </div>
+            </div>
+
+            <div class="panel panel-default">
+                <table class="table table-hover">
+                    <?php foreach ($closed_issues as $i) { ?>
+                        <?=datalsts\issueListItem($i)?>
+                    <?php } ?>
+                </table>
+            </div>
+        </div>
+
+        <?=stdpage\foot()?>
+    </body>
+</html>
-- 
cgit v1.2.3


From a78cfba0975eaa45540edca95835f302cbb86cef Mon Sep 17 00:00:00 2001
From: Malf Furious <m@lfurio.us>
Date: Mon, 5 Nov 2018 03:45:48 -0500
Subject: Add link to closed issues view

Signed-off-by: Malf Furious <m@lfurio.us>
---
 app/view/pad.php | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

(limited to 'app/view')

diff --git a/app/view/pad.php b/app/view/pad.php
index a9c8508..bf626bf 100644
--- a/app/view/pad.php
+++ b/app/view/pad.php
@@ -42,9 +42,15 @@ require_once "view/issue.php";
                             <span class="glyphicon glyphicon-edit"></span>
                             <?=$pad->name?>
 
-                            <button type="button" class="btn btn-success" data-toggle="modal" data-target="#newIssueModal">
-                                <span class="glyphicon glyphicon-plus"></span> Open Issue
-                            </button>
+                            <div class="btn-group">
+                                <button type="button" class="btn btn-success" data-toggle="modal" data-target="#newIssueModal">
+                                    <span class="glyphicon glyphicon-plus"></span> Open Issue
+                                </button>
+
+                                <a href="<?=ap()?>/closed" class="btn btn-default">
+                                    View closed issues
+                                </a>
+                            </div>
                         </h1>
                     </div>
                 </div>
-- 
cgit v1.2.3


From daa4f7a34e23d18e23d34d4becca752635b2ea38 Mon Sep 17 00:00:00 2001
From: Malf Furious <m@lfurio.us>
Date: Mon, 5 Nov 2018 04:21:49 -0500
Subject: Only display 'iss-mesg-add' form for open issues

Disallow posting to closed issues.  This is a temporary soultion and
will likely be reverted in the future.  The main reason this is being
done now is because this form, as written, depends on an open issue
state.

To aid diff comprehension, note that most lines are only indented one
level, the code area affected is wrapped in a PHP if.

Note that form submissions are still allowed for closed issues.  This
commit only disable the _displaying_ of the form.

Signed-off-by: Malf Furious <m@lfurio.us>
---
 app/view/issue.php | 86 ++++++++++++++++++++++++++++--------------------------
 1 file changed, 44 insertions(+), 42 deletions(-)

(limited to 'app/view')

diff --git a/app/view/issue.php b/app/view/issue.php
index 5f1c518..6edf7cf 100644
--- a/app/view/issue.php
+++ b/app/view/issue.php
@@ -109,53 +109,55 @@ require_once "class/issue.class.php";
                                 </div>
                             <?php } ?>
 
-                            <form method="post" action="<?=ap()?>" enctype="multipart/form-data">
-                                <?=\formctrl\formname( "iss-mesg-add" )?>
-                                <?=\formctrl\hidden( "issue", $i->guid )?>
-                                <?=\formctrl\textarea( "New message", "mesg", 5 )?>
-
-                                <div class="btn-group pull-right">
-                                    <button type="submit" name="input[postMesg]" class="btn btn-primary" title="Post message">
-                                        <span class="glyphicon glyphicon-envelope"></span>
-                                    </button>
-
-                                    <button type="submit" name="input[closeIssue]" class="btn btn-default" title="Close issue">
-                                        <span class="glyphicon glyphicon-ok"></span>
-                                    </button>
-
-                                    <button type="submit" name="input[advIssue]" class="btn btn-default" title="Advance issue">
-                                        <span class="glyphicon glyphicon-chevron-up"></span>
-                                    </button>
-
-                                    <button type="button" class="btn btn-default" data-toggle="collapse" data-target="#assignCollapse-<?=$i->guid?>" title="Assign issue">
-                                        <span class="glyphicon glyphicon-share-alt"></span>
-                                    </button>
-                                </div>
-
-                                <div class="collapse" id="assignCollapse-<?=$i->guid?>">
-                                    <div class="form-group">
-                                        <label>Select assignee</label>
+                            <?php if ($i->isOpen()) { ?>
+                                <form method="post" action="<?=ap()?>" enctype="multipart/form-data">
+                                    <?=\formctrl\formname( "iss-mesg-add" )?>
+                                    <?=\formctrl\hidden( "issue", $i->guid )?>
+                                    <?=\formctrl\textarea( "New message", "mesg", 5 )?>
+
+                                    <div class="btn-group pull-right">
+                                        <button type="submit" name="input[postMesg]" class="btn btn-primary" title="Post message">
+                                            <span class="glyphicon glyphicon-envelope"></span>
+                                        </button>
+
+                                        <button type="submit" name="input[closeIssue]" class="btn btn-default" title="Close issue">
+                                            <span class="glyphicon glyphicon-ok"></span>
+                                        </button>
+
+                                        <button type="submit" name="input[advIssue]" class="btn btn-default" title="Advance issue">
+                                            <span class="glyphicon glyphicon-chevron-up"></span>
+                                        </button>
+
+                                        <button type="button" class="btn btn-default" data-toggle="collapse" data-target="#assignCollapse-<?=$i->guid?>" title="Assign issue">
+                                            <span class="glyphicon glyphicon-share-alt"></span>
+                                        </button>
+                                    </div>
 
-                                        <select name="input[assignee]" class="form-control selectpicker">
-                                            <option data-icon="glyphicon-user" value="<?=$i->getParent()->getParent()->getOwner()->guid?>">
-                                                <?=$i->getParent()->getParent()->getOwner()->getDisplayName()?>
-                                            </option>
+                                    <div class="collapse" id="assignCollapse-<?=$i->guid?>">
+                                        <div class="form-group">
+                                            <label>Select assignee</label>
 
-                                            <?php foreach ($i->getParent()->getParent()->getMembers() as $memb) { ?>
-                                                <option data-icon="glyphicon-user" value="<?=$memb->guid?>">
-                                                    <?=$memb->getDisplayName()?>
+                                            <select name="input[assignee]" class="form-control selectpicker">
+                                                <option data-icon="glyphicon-user" value="<?=$i->getParent()->getParent()->getOwner()->guid?>">
+                                                    <?=$i->getParent()->getParent()->getOwner()->getDisplayName()?>
                                                 </option>
-                                            <?php } ?>
-                                        </select>
-                                    </div>
 
-                                    <button type="submit" name="input[assIssue]" class="btn btn-default">
-                                        <span class="glyphicon glyphicon-share-alt"></span> Post and assign issue
-                                    </button>
-                                </div>
+                                                <?php foreach ($i->getParent()->getParent()->getMembers() as $memb) { ?>
+                                                    <option data-icon="glyphicon-user" value="<?=$memb->guid?>">
+                                                        <?=$memb->getDisplayName()?>
+                                                    </option>
+                                                <?php } ?>
+                                            </select>
+                                        </div>
+
+                                        <button type="submit" name="input[assIssue]" class="btn btn-default">
+                                            <span class="glyphicon glyphicon-share-alt"></span> Post and assign issue
+                                        </button>
+                                    </div>
 
-                                <?=\formctrl\file( "Attachment", "attachment" )?>
-                            </form>
+                                    <?=\formctrl\file( "Attachment", "attachment" )?>
+                                </form>
+                            <?php } ?>
                         </div>
 
                         <div class="col-md-4">
-- 
cgit v1.2.3


From be18c21941eb1309047e5cede3467cc538e71559 Mon Sep 17 00:00:00 2001
From: Malf Furious <m@lfurio.us>
Date: Sat, 10 Nov 2018 09:21:54 -0500
Subject: Fix bug in assignee selection

Previously, issues on pads owned by a group (rather than by a user)
would incorrectly present options for user assignment.  It would show
the group as a member of the list, misleadingly with the user icon to
the left of it.

This patch uses the new agent::getContainedUsers() function to resolve
the pad's owner to an array of users accessible via the owner 'agent'.

Signed-off-by: Malf Furious <m@lfurio.us>
---
 app/view/issue.php | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

(limited to 'app/view')

diff --git a/app/view/issue.php b/app/view/issue.php
index 6edf7cf..01a9f5f 100644
--- a/app/view/issue.php
+++ b/app/view/issue.php
@@ -138,9 +138,11 @@ require_once "class/issue.class.php";
                                             <label>Select assignee</label>
 
                                             <select name="input[assignee]" class="form-control selectpicker">
-                                                <option data-icon="glyphicon-user" value="<?=$i->getParent()->getParent()->getOwner()->guid?>">
-                                                    <?=$i->getParent()->getParent()->getOwner()->getDisplayName()?>
-                                                </option>
+                                                <?php foreach ($i->getParent()->getParent()->getOwner()->getContainedUsers() as $memb) { ?>
+                                                    <option data-icon="glyphicon-user" value="<?=$memb->guid?>">
+                                                        <?=$memb->getDisplayName()?>
+                                                    </option>
+                                                <?php } ?>
 
                                                 <?php foreach ($i->getParent()->getParent()->getMembers() as $memb) { ?>
                                                     <option data-icon="glyphicon-user" value="<?=$memb->guid?>">
-- 
cgit v1.2.3


From dc82ea4c3ab3892d9f94cae73832d2c09e2ad3b2 Mon Sep 17 00:00:00 2001
From: Malf Furious <m@lfurio.us>
Date: Sat, 10 Nov 2018 09:31:05 -0500
Subject: Add 'No issues' message to empty stage list items

Signed-off-by: Malf Furious <m@lfurio.us>
---
 app/view/datalsts.php | 4 ++++
 1 file changed, 4 insertions(+)

(limited to 'app/view')

diff --git a/app/view/datalsts.php b/app/view/datalsts.php
index 2bbb44e..ba9021b 100644
--- a/app/view/datalsts.php
+++ b/app/view/datalsts.php
@@ -118,6 +118,10 @@ require_once "class/issue.class.php";
     <div class="panel panel-default">
         <h2 class="text-center"><?=$s->name?></h2>
 
+        <?php if (count($s->getIssues_ordByDueByNumb()) == 0) { ?>
+            <h4 class="text-info text-center">No issues</h4>
+        <?php } ?>
+
         <table class="table table-hover">
             <?php foreach ($s->getIssues_ordByDueByNumb() as $i) { ?>
                 <?=issueListItem($i)?>
-- 
cgit v1.2.3


From d238e84bc894a067911c33533d2f13e3007f390e Mon Sep 17 00:00:00 2001
From: Malf Furious <m@lfurio.us>
Date: Sat, 10 Nov 2018 22:29:33 -0500
Subject: Add 'No issues' message to empty closed issue list

Signed-off-by: Malf Furious <m@lfurio.us>
---
 app/view/pad_closed.php | 4 ++++
 1 file changed, 4 insertions(+)

(limited to 'app/view')

diff --git a/app/view/pad_closed.php b/app/view/pad_closed.php
index 19864cd..e11ca84 100644
--- a/app/view/pad_closed.php
+++ b/app/view/pad_closed.php
@@ -51,6 +51,10 @@ require_once "view/issue.php";
             </div>
 
             <div class="panel panel-default">
+                <?php if (count($closed_issues) == 0) { ?>
+                    <h4 class="text-info text-center">No closed issues</h4>
+                <?php } ?>
+
                 <table class="table table-hover">
                     <?php foreach ($closed_issues as $i) { ?>
                         <?=datalsts\issueListItem($i)?>
-- 
cgit v1.2.3