From c7601e5305295a635c6ddac61816aac77caa7bb7 Mon Sep 17 00:00:00 2001
From: Malf Furious <m@lfurio.us>
Date: Sat, 12 Jan 2019 19:42:33 -0500
Subject: Automatically signoff assignee when closing issue

For the Scrott alpha, there is no way for assignees to signoff their
work.  As a workaround, I am now just always signing off somebody when
they close an issue.  This will slightly improve the user experience for
now, but I'm leaving the real fix for the beta.

Signed-off-by: Malf Furious <m@lfurio.us>
---
 app/model/issue.php | 2 ++
 1 file changed, 2 insertions(+)

(limited to 'app/model')

diff --git a/app/model/issue.php b/app/model/issue.php
index 7159015..b78e93a 100644
--- a/app/model/issue.php
+++ b/app/model/issue.php
@@ -68,6 +68,7 @@ if (isAction("iss-mesg-add"))
         }
         else
         {
+            $issue->signoffAssignee($user);
             $log = mesg::initNewLog("%s closed issue", $user, $issue);
         }
     }
@@ -97,6 +98,7 @@ if (isAction("iss-mesg-add"))
             return;
         }
 
+        $issue->signoffAssignee($user);
         $issue->close($user);
         logError(NOTICE, "Issue #" . $issue->numb . " closed");
         $log = mesg::initNewLog("%s closed issue", $user, $issue);
-- 
cgit v1.2.3


From 498f4d77d2868780e9975085fa9a2e8ebbe75ea3 Mon Sep 17 00:00:00 2001
From: Malf Furious <m@lfurio.us>
Date: Sat, 12 Jan 2019 21:46:56 -0500
Subject: Automatically show updated issues on page reload

When submitting the iss-mesg-add form and reloading the page, this line
will inform the stdpage footer javascript to automatically show the
affected issue modal.

This is _really_ helpful when trying to make multiple POSTs to an issue,
as the user is not taken out of the issue modal between each POST,
requiring them to visually find it again in the list of open tickets.

Signed-off-by: Malf Furious <m@lfurio.us>
---
 app/model/issue.php | 3 +++
 1 file changed, 3 insertions(+)

(limited to 'app/model')

diff --git a/app/model/issue.php b/app/model/issue.php
index b78e93a..a9f6961 100644
--- a/app/model/issue.php
+++ b/app/model/issue.php
@@ -103,6 +103,9 @@ if (isAction("iss-mesg-add"))
         logError(NOTICE, "Issue #" . $issue->numb . " closed");
         $log = mesg::initNewLog("%s closed issue", $user, $issue);
     }
+
+    /* automatically redisplay issue modal */
+    setAutoModal("#issueModal-" . $issue->guid);
 }
 
 ?>
-- 
cgit v1.2.3


From d71c72ba57abee645daf658bbdb74f296406171d Mon Sep 17 00:00:00 2001
From: Malf Furious <m@lfurio.us>
Date: Sat, 12 Jan 2019 22:22:22 -0500
Subject: Display confirmation message when closing issue by advancing it

This is to make the user experience more uniform, but is in-part to
mitigate a bug.

Since the auto issue showing has been added, this will cause the newly
closed issue to try and come up after we advance it past the last stage.
Since we have just closed the issue, its modal is in a weird state.
This informational notice modal prevents that broken issue modal from
displaying.

Signed-off-by: Malf Furious <m@lfurio.us>
---
 app/model/issue.php | 1 +
 1 file changed, 1 insertion(+)

(limited to 'app/model')

diff --git a/app/model/issue.php b/app/model/issue.php
index a9f6961..dd904e4 100644
--- a/app/model/issue.php
+++ b/app/model/issue.php
@@ -69,6 +69,7 @@ if (isAction("iss-mesg-add"))
         else
         {
             $issue->signoffAssignee($user);
+            logError(NOTICE, "Issue #" . $issue->numb . " closed");
             $log = mesg::initNewLog("%s closed issue", $user, $issue);
         }
     }
-- 
cgit v1.2.3