| Age | Commit message (Collapse) | Author | Files | Lines |
|---|
|
First button added to the header of pad views is to open new issues.
This interface is still very crude and subject to change in the near
future.
Signed-off-by: Malf Furious <m@lfurio.us>
|
|
When viewing a pad, offer the 'New Issue' option under the additions
menu in the navbar. Will will display the just-added new issue modal,
for the user to open a new issue on the first stage of the pad being
viewed.
Signed-off-by: Malf Furious <m@lfurio.us>
|
|
This datamods modal is accessable from pad views to open a new issue on
the pad in question. This is a simplistic version of this interface,
subject to improvements once I start on the v0.2-v0.3 development
iteration. Suffice it to say, any frills we will want to use in the
initial draft will be accessible from the issue view modal, as options
to modify the open issue.
Signed-off-by: Malf Furious <m@lfurio.us>
|
|
Adds a parameterized text area to the collection of controls.
Signed-off-by: Malf Furious <m@lfurio.us>
|
|
Updated the javascript to wire-up the issue list items shown on pad
views. When these are clicked the associated issue modal is displayed
in the foreground.
|
|
This logic instanciates an issue modal view for each issue to be
accessable from a pad view.
|
|
|
|
|
|
This reverts commit 62872702dc413b7abab94d8a5a7bd21770b5d241.
|
|
|
|
Revised implementation of redesigned data model.
|
|
I found myself complicating the data model of this class of objects and
wanted to take a clean approach to its design. The key differences are
as follows:
* We now reference a message object for the issue's OP, as
opposed to directly containing the message data
This affords the OP _all_ of the standard features of a Scrott
message, including separately tracked authorship data, file
attachments.
* Multiple assignees is implemented in the design
Finally.
* Seen flag is removed
This can be implicitly tracked via all sub-object messages and
the views meta-table.
|
|
This function is patched to co-operate with structural changes to the
issue class.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
A dependency loop exists between class/agent.class.php and
class/group.class.php. Due to specific `require_once` ordering within
the app, this problem was not surfaced until now.
These two classes depend on eachother, but strictly speaking, the
interpreter needs to read the agent class first. This is because group
directly inherits from agent. It is only one of agent's functions which
references group. Group has a `require_once "class/agent.class.php"` at
its top, so requiring group first will read both classes, in the correct
order, and provide their definition's for the remainder of the runtime.
The main entry-point, index.php, did not have this problem since it was
explicitly requiring group itself (it actually needs group, though).
The df.php entry-point wasn't and was relying on requires in the class/
directory to resolve this issue. In a more-sane language, I could patch
this more easily directly in the affected file; rather, this patch
updates the df entry-point to explicitly require group, solving the
issue up front.
Hopefully this can be fleshed out in the future as it should not consern
the entry-points that this specific evaluation order needs to take
place.
The third and final entry-point, cron.php, is already fine at the time
of this commit. Its require tree is much simplier, and does not even
include either of the affected classes.
|
|
|
|
This is probabally more of an oops than a bug, although was causing
unexpected behavior.
When falling back to checking whether the agent has access to the
object's owner, it was wrongly accessing through $this->owner, rather
than $obj->owner (which is the function argument). This was probabally
left over from how this function _used_ to be implemented (you would
call on the object and pass in the user).
|
|
|
|
|
|
|
|
There was a problem with processing enum type fields. The way all other
field types are asserted to be 'defined' is via:
isset($field) && $field != ""
Which works perfectly fine, and is exactly what we want. However, with
enums the second part of that && can bite us if "" is in the list of
acceptable values.
This commit removed that half of the check (only for enum values) so
that the empty string may be an acceptable enum value. If "" is not in
the values array, then the check is implicitly reinstated.
|
|
|
|
Because of how this function was implemented, any failure during
database instance construction is treated the same way. IE. we cannot
tell the difference between 'no db config' (as is the initial default
state) and a 'bad db config' (either bogus data, or the server happens
to be down).
Because of this, if, after the database access is initially set up,
access to the db becomes unavailable or someone makes a bad edit to the
dbconfig.php file, Scrott behaves as if it is being configured for the
first time. This is *dangerous* behavior! (unexpected, at the least)
The implication of this is that if Scrott's database access is ever
incidentially interrupted, the very next visitor to the site is offered
the chance to (silently) reconfigure the server to point to any database
of his choosing.
This patch updates the checkConfig() function to only 'soft fail'
(return false) in the case where the configuration is _actually_
missing. IE. $_SCROTT['conf'] is not defined. This function will
otherwise passthrough any and all exceptions which result from
instanciating the database instance and will only return true if both of
these steps succeed.
|
|
This is an interface to alter the settings stored in the 'settings'
database table. Typically restricted to administrators only.
|
|
This is not meant to be a user (admin) configurable key. Rather, this
is a mechanism for success/failure results from interactions with
PHPMailer to make their way back to the UI. Down the road, email
sending functions should publish their true/false return value to this
configuration key. The initial default value of "NULL" means no mail
send attempts have taken place.
|
|
|
|
|
|
|
|
|
|
The controller now (again) prevents browsing to objects the user is not
allowed to access.
|
|
This places all (both) of the service configuration files together and
cleans up the top-level directory. The file is renamed to 'mysql.sql'
to indicate the particular service it corresponds to.
|
|
|
|
I was experiencing problems on Mysql proper with the way Scrott
interacts with the database when forming new objects. It attempts some
writeback querries before all attributes are applied to the new objects.
This makes sense if you understand how many initNew and helper functions
are implemented. As a convenience a function which mutates an object
will also apply its changes to the database automatically. These
function are used instead of directly settings PHP object properties
because there are additional pieces of logic performed to ensure
everything remains valid in the datamodel.
As was the case for a few types of objects, cirtain functions which
behave this way were being called during an object's initNew(), causing
DB writebacks to occur before some other 'default-less' field had been
defined for that object.
This patch provides some 'not so invalid' default states for database
table columns which were previously undefined. This should also
mitigate some issues I may have not run unto yet.
|
|
I don't mean to impose a character limit here, so I am changing this
type to 'text'. As per the previous commit, the default value is also
removed.
|
|
It is an error in Mysql for columns of type 'text' to have a default
value. Removing these resolves Mysql errors and MariaDB warnings.
|
|
|
|
|
|
In cases where the pad had no stages beneath it, `new
stage($this->stage)` would construct an invalid object. As it turns
out, calling ->getArray() on an uninitialized stage object yeilds bad
results.
Instead of patching the stage::getArray() function, I add a check to
harden pad::getStages(). My reasoning for this is as follows: The bug
in getArray() manifests from a domain error, ie. it's only because we
are calling it on an uninitialized object. The object is already in a
bad state prior to caling getArray(). Rather, I opt to patch
getStages() so that we never create a bad object in the first place.
Now, for no-stage pads, getStages() will return early an empty array.
|
|
This particular flaw was dampening (and could popentially be hiding) the
effects of other bugs.
For instance, in this case, a GUID of "" was invalidly being used to
construct an object. This should obviously be considered an error, but
since "" evaluates to false, the construction was treated as default (no
GUID) construction and succedded. It wasn't until later when missing
properties were accessed that random PHP error messages clued me into what
was happening.
Now, when any sort of explicit value is used to construct an object (not
NULL), an object load will be attempted, giving bad input more chances
to fail outright and trigger an exception. In addition, the 'no such
guid' exception message is updated to place quotes ('') around the GUID
string to make it more obvious when "" is used in the future.
|
|
Removed placholder text and now displaying the logged-in user's display
name. This is accopanied by the user icon and (conditionally) the
'cool' sunglasses icon for admins. This is similar, but not identical,
to the markup of my old archived code I'm clearing out.
|
|
This additional spacing is added to the navbar text to improve its
appearance in the browser.
|
|
As a convenience, I'm adding a basic set of stages to new pads. These
stages are "To Do", "In Progress" ('Done' being closed issues). This
implements a very simple workflow for new pads.
|
|
These two functions, 'getCurrentTimestamp()' and 'isGUID()' are updated
to be public. There is actually no good reason for them to be private;
I originally just never antisipated their use outside this class.
I need isGUID() in index.php to help with page routing. Neither of
these two functions have side effects of any kind nor any unexpected
behavior, so there is no harm in going public.
|
|
Removing these unnecessary checks. They are not protecting us from
anything, only inconveniencing me in index.php.
|
|
|
