issue: Fix bug in functions advance() and close()

If the issue is already closed, these functions should do nothing.
Continuing the logic in these functions could currupt the database.

1 files changed, 6 insertions, 1 deletions

diff --git a/app/class/issue.class.php b/app/class/issue.class.php
index 1286e1a..3127a87 100644
--- a/app/class/issue.class.php
+++ b/app/class/issue.class.php
@@ -98,6 +98,9 @@ class issue extends object
     {
         $stage = $this->getParent();
 
+        if ($stage->objtype != "stage")
+            return;
+
         if (!($next = $stage->getNext()))
             $this->close();
         else
@@ -110,7 +113,9 @@ class issue extends object
     public function close() : void
     {
         $pad = $this->getParent()->getParent();
-        $this->setParent($pad);
+
+        if ($pad)
+            $this->setParent($pad);
     }
 }