From 43a3d5cd4d816ca45fc0d725e161ed2a4bf066cf Mon Sep 17 00:00:00 2001 From: Malfurious Date: Sat, 12 Aug 2023 19:15:54 -0400 Subject: Fix regression in the full acme-companion configuration >They are not needed anyway. turned out to be wrong I had previously removed definitions for the container's `container_name` parameters to troubleshoot an issue, but I had misunderstood the cause of the problem. In fact, even though the use of the NGINX_PROXY_CONTAINER variable on the acme service didn't appear in any documentation I read, it _was_ serving a purpose in helping the two containers communicate. I still prefer to not use the container_name parameter, so instead, apply the correct label to the main nginx-proxy container in this configuration. This actually appears to be the first method used by acme-companion to locate the container. Signed-off-by: Malfurious --- docker-compose-acme.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docker-compose-acme.yml b/docker-compose-acme.yml index 51ce003..eafaa38 100644 --- a/docker-compose-acme.yml +++ b/docker-compose-acme.yml @@ -28,6 +28,8 @@ services: ports: - "80:80" - "443:443" + labels: + - "com.github.nginx-proxy.nginx" # https://github.com/nginx-proxy/acme-companion acme-companion: -- cgit v1.2.3